Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bazel rule to compile protos during the initial generation #866

Open
summer-ji-eng opened this issue May 6, 2021 · 0 comments
Open

Use bazel rule to compile protos during the initial generation #866

summer-ji-eng opened this issue May 6, 2021 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@summer-ji-eng
Copy link
Collaborator

Current: bazel generates a library without compiled protos, so it's expected that someone (synthtool, OwlBot, etc.) will call "npm run compile-protos" later in the process

Downside: so it's a post-processing step that is quite expensive and fragile

Improve: would be better if the protos were compiled during the initial generation step by bazel, to reduce the number of things that could break in post-processing

Discuss this feature in June 2021 sprint
@summer-ji-eng summer-ji-eng added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 6, 2021
This was referenced Jul 9, 2021
Closed
Closed
@hkdevandla hkdevandla removed their assignment Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@summer-ji-eng @hkdevandla @alicejli