Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech debt: integration tests are broken #860

Open
alexander-fenster opened this issue Apr 29, 2021 · 1 comment
Open

tech debt: integration tests are broken #860

alexander-fenster opened this issue Apr 29, 2021 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@alexander-fenster
Copy link
Contributor

Even worse: they are broken but shown as passing.

$ npm run js-test-application
$ npm run ts-test-application

should work properly, and must fail if the tests actually failed. Right now, the tests fail but the failures are not detected. This needs to be fixed (probably in multiple places).
@alexander-fenster alexander-fenster changed the title eng debt: integration tests are broken tech debt: integration tests are broken Apr 29, 2021
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 30, 2021
@miraleung miraleung added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. and removed triage me I really want to be triaged. 🚨 This issue needs some love. labels May 5, 2021
@alexander-fenster
Copy link
Contributor Author

Now they are actually failing, and need to be fixed properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexander-fenster @miraleung @yoshi-automation