Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy test fails with gapic-generator-python 0.65.2 #1288

Closed
parthea opened this issue Apr 28, 2022 · 2 comments
Closed

mypy test fails with gapic-generator-python 0.65.2 #1288

parthea opened this issue Apr 28, 2022 · 2 comments
Assignees
@parthea
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Apr 28, 2022

The following code is failing the mypy test in googleapis/python-datastore#306

        metadata = tuple(metadata) + (
            gapic_v1.routing_header.to_grpc_metadata((("project_id", ""),)),
        )

The error is

nox > mypy google/ tests/
tests/unit/gapic/datastore_admin_v1/test_datastore_admin.py:1817: error: Incompatible types in assignment (expression has type "Tuple[Any, ...]", variable has type "Tuple[]")

See build log here.

@atulep Please could you take a look?
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 28, 2022
@parthea parthea mentioned this issue Apr 28, 2022
Merged
1 task
@parthea parthea assigned parthea and unassigned atulep May 7, 2022
@parthea parthea mentioned this issue May 9, 2022
Closed
@parthea parthea mentioned this issue May 16, 2022
Closed
@vam-google
Copy link
Contributor

@parthea Can you please revisit your #1314 PR and merge it if possible? This issue isnow showing as out of SLO for us. Thanks!

@parthea
Copy link
Contributor Author

parthea commented Feb 16, 2023

Closing as obsolete.

@parthea parthea closed this as completed Feb 16, 2023
@parthea parthea reopened this Feb 16, 2023
@parthea parthea closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
3 participants
@parthea @atulep @vam-google