Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read cells-per-row option. #94

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

icio
Copy link

@icio icio commented Aug 10, 2022

Fixes #99

@google-cla
Copy link

google-cla bot commented Aug 10, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@telpirion
Copy link
Contributor

Hi @icio ! Thank you for this feature work. Would you please open an issue to correspond to this work? Thank you.

@icio
Copy link
Author

icio commented Aug 15, 2022

@telpirion Done: #99. Referenced from the PR description.

Copy link
Contributor

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your addition to the tool!

@telpirion telpirion added the automerge Merge the pull request once unit tests and other checks pass. label Aug 22, 2022
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 23, 2022
@icio
Copy link
Author

icio commented Nov 6, 2022

Worth retrying?

@icio icio requested a review from a team as a code owner November 16, 2022 11:20
@icio
Copy link
Author

icio commented Nov 16, 2022

@telpirion Merge conflict resolved so this might be good to go now.

@enocom enocom removed their request for review November 16, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: cbt read cells-per-row option
2 participants