Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AIP-122): resource patterns must start with lowercase letter #995

Merged

Conversation

shwoodard
Copy link
Collaborator

@shwoodard shwoodard commented Aug 5, 2022

Resource patterns must start with lowercase letters per AIP-122.

Fixes #994

Lint for when resource patterns start with slash.
@shwoodard shwoodard requested a review from a team as a code owner August 5, 2022 12:55
Lint for that resource patterns start with a lowercase letter rather
than just that they don't start with a slash, per the AIP.
@shwoodard shwoodard changed the title Lint for that resource patterns do not start with slashes Lint for that resource patterns starts with lowercase letter. Aug 5, 2022
@noahdietz noahdietz changed the title Lint for that resource patterns starts with lowercase letter. feat(AIP-122): resource patterns must start with lowercase letter Aug 5, 2022
@noahdietz
Copy link
Collaborator

I guess the Go linting wants you to run goimports on the changed directory?

@noahdietz noahdietz merged commit a8bbf7c into googleapis:main Aug 5, 2022
@shwoodard shwoodard deleted the patterns-cannot-start-with-slash branch August 8, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter crashes with index out of bounds when there is a slash at the front of a resource pattern
2 participants