Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AIP-191): compare service casing to packaging #984

Merged
merged 6 commits into from
Jun 27, 2022
Merged

feat(AIP-191): compare service casing to packaging #984

merged 6 commits into from
Jun 27, 2022

Conversation

noahdietz
Copy link
Collaborator

A first step towards protecting services and packing annotations from having mismatched names e.g. service Foobar and option c_sharp_namespace = "Google.FooBar.V1" where Foobar and FooBar do not match in casing.

@jskeet

@noahdietz noahdietz requested a review from a team as a code owner June 22, 2022 23:08
GregFurmanek
GregFurmanek reviewed Jun 23, 2022
View reviewed changes
Copy link
Contributor

@GregFurmanek GregFurmanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this basically ensures that we treat all definitions in a case sensitive manner, correct?

rules/aip0191/csharp_namespace.go Outdated Show resolved Hide resolved
rules/aip0191/csharp_namespace_test.go Outdated Show resolved Hide resolved
@noahdietz
Copy link
Collaborator Author

So this basically ensures that we treat all definitions in a case sensitive manner, correct?

Yep. It is common (per Client libs team) to have mismatched proto packaging annotation values and service name as the former is just a string and is easy to mess up, whereas the service name itself is much more of a "first class" element.

@googleapis googleapis deleted a comment from reinasalondra Jun 27, 2022
@noahdietz noahdietz added the automerge Summon MOG for automerging label Jun 27, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2aa02dc into googleapis:main Jun 27, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Jun 27, 2022
@noahdietz noahdietz deleted the packaging-issues branch June 27, 2022 18:09
reinasalondra
reinasalondra reviewed Jun 27, 2022
View reviewed changes
Copy link

@reinasalondra reinasalondra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noahdietz:packaging-issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinasalondra reinasalondra reinasalondra approved these changes

@GregFurmanek GregFurmanek GregFurmanek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noahdietz @GregFurmanek @reinasalondra