fix: handle unresolvable lro response types AIP-133 and AIP-233 #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwoodard
reviewed
Jun 13, 2022
…inter into fix-unresolvable
shwoodard
requested changes
Jun 13, 2022
shwoodard
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #978 for both AIP-233 and AIP-133.
Also adds some helpers for getting the ResponseType and MetadataType from the OperationInfo.
Unfortunately, the
protoreflectlibrary used in this project does not handle thenilreceiver case on proto descriptors like protobuf-go does (i.e. if a descriptor being used as a receiver isnil, the method will return the default unset value for the field being accessed).