Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TODOs and safety comments once rust-lang/reference#1392 is stable #440

Closed
joshlf opened this issue Oct 1, 2023 · 0 comments · Fixed by #462
Closed

Update TODOs and safety comments once rust-lang/reference#1392 is stable #440

joshlf opened this issue Oct 1, 2023 · 0 comments · Fixed by #462
Labels
blocked-on-rust Blocked on a Rust feature landing or stabilizing compatibility-nonbreaking Changes that are (likely to be) non-breaking

Comments

@joshlf
Copy link
Member

joshlf commented Oct 1, 2023 •
edited

rust-lang/reference#1392 added bit validity guarantees for various types. Once that text has been included in a stable release, we can update various TODOs and safety comments which depended on it or on rust-lang/reference#1291.

EDIT: This is implemented in #462, but that PR can't be merged until the new reference text is included in a stable release.
@joshlf joshlf added the compatibility-nonbreaking Changes that are (likely to be) non-breaking label Oct 1, 2023
joshlf added a commit that referenced this issue Oct 4, 2023
@joshlf
Safety comments quote new bit validity guarantees
f94c1ac 
rust-lang/reference#1392 adds bit validity
guarantees for numeric types. This commit makes use of those guarantees
to provide stronger soundness justifications for some trait impls.

Closes #440
@joshlf joshlf mentioned this issue Oct 4, 2023
Merged
@joshlf joshlf added the blocked-on-rust Blocked on a Rust feature landing or stabilizing label Oct 4, 2023
joshlf added a commit that referenced this issue Nov 15, 2023
@joshlf
Safety comments quote new bit validity guarantees
3effe73 
rust-lang/reference#1392 adds bit validity
guarantees for numeric types. This commit makes use of those guarantees
to provide stronger soundness justifications for some trait impls.

Closes #440
github-merge-queue bot pushed a commit that referenced this issue Nov 15, 2023
@joshlf
Safety comments quote new bit validity guarantees (#462)
29022e4 
rust-lang/reference#1392 adds bit validity
guarantees for numeric types. This commit makes use of those guarantees
to provide stronger soundness justifications for some trait impls.

Closes #440
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked-on-rust Blocked on a Rust feature landing or stabilizing compatibility-nonbreaking Changes that are (likely to be) non-breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Safety comments quote new bit validity guarantees google/zerocopy
1 participant
@joshlf