Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language to refer to u8s instead of bytes #278

Open
joshlf opened this issue Aug 21, 2023 · 1 comment
Open

Update language to refer to u8s instead of bytes #278

joshlf opened this issue Aug 21, 2023 · 1 comment
Labels
compatibility-nonbreaking Changes that are (likely to be) non-breaking

Comments

@joshlf
Copy link
Member

joshlf commented Aug 21, 2023

As this discussion demonstrates, there is a lot of subtlety around what constitutes a "byte" in Rust's abstract machine. By contrast, it is sufficient to define the bit validity of most types in reference to u8s without actually specifying much about the bit validity of u8 itself. Since most of our conversions operate in terms of existing u8 types (usually [u8]), this isn't a problem for us. We should replace most uses of "byte sequence" with a similar phrase involving u8s.

@joshlf joshlf added the compatibility-nonbreaking Changes that are (likely to be) non-breaking label Aug 21, 2023
@RalfJung
Copy link

For the curious, we now have a definition of "byte" in the UCG glossary. This is not normative though, it is a WIP definition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility-nonbreaking Changes that are (likely to be) non-breaking
Projects
None yet
Development

No branches or pull requests

2 participants