You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#[diagnostic::on_unimplemented] (documented here) was stabilized in 1.78. Even though our MSRV is lower than 1.78, we can use our toolchain version detection in build.rs to detect 1.78, and use this to conditionally emit this attribute on some of our public traits, which might improve our ergonomics.
Note:
Good candidates are the HasPadding and ShouldBe traits used to detect padding when deriving IntoBytes
For derived traits, it would be ideal to emit a different error message if the trait is not implemented syntactically (ie, not derived) than if the trait is derived but there are unsatisfied trait bounds
#[diagnostic::on_unimplemented]
(documented here) was stabilized in 1.78. Even though our MSRV is lower than 1.78, we can use our toolchain version detection inbuild.rs
to detect 1.78, and use this to conditionally emit this attribute on some of our public traits, which might improve our ergonomics.Note:
HasPadding
andShouldBe
traits used to detect padding when derivingIntoBytes
Candidates for errors to fix:
Immutable
#1296The text was updated successfully, but these errors were encountered: