Allow lines parameter to fix whitespace between statements.
#864
+24
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic considered all components of the generator in a single-argument call such as 'f(a for a in x)' to be strongly connected like a normal single-argument call (e.g. 'f(a_var)'). This caused formatting irregularities in these cases. This change retains normal split penalties in the single-argument generator case.
The previous logic largely ignored `lines` values that were not part of statements. This means that yapf required a statement to be formatted to make whitespace-only changes. This logic tweak allows `lines` to be taken into account even when the adjacent statements are disabled (i.e. not in `lines`).
|
Coverage doesn't really look like it decreased. Could have just been the result of removing some code. |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic largely ignored
linesvalues that were not part ofstatements. This means that yapf required a statement to be formatted to
make whitespace-only changes.
This logic tweak allows
linesto be taken into account even when theadjacent statements are disabled (i.e. not in
lines).