Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NewString Func #73

Merged
merged 2 commits into from Jan 22, 2021
Merged

Add NewString Func #73

merged 2 commits into from Jan 22, 2021

Conversation

jackterm
Copy link
Contributor

@jackterm jackterm commented Jan 22, 2021

  • Adds NewString() func, which encapsulates the more verbose New().String()
  • We use New().String() for testing, and it feels ugly. Rather than adding a wrapper around google/uuid, figured it makes sense to add the utility method to the root package

@google-cla
Copy link

google-cla bot commented Jan 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jackterm
Copy link
Contributor Author

@googlebot I signed it!

version4.go Outdated Show resolved Hide resolved
version4.go Outdated Show resolved Hide resolved
@pborman pborman merged commit bfb86fa into google:master Jan 22, 2021
@pborman
Copy link
Collaborator

pborman commented Jan 22, 2021

Thank you, this looks good and is a nice addition (it is actually the equivalent of gitHub.com/pborman/uuid.New() which was the original package (but now is implemented in terms of this package). I think that was one thing people missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants