Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash.go hash error covered and linter error fixed #71

Merged
merged 2 commits into from Jan 15, 2021
Merged

hash.go hash error covered and linter error fixed #71

merged 2 commits into from Jan 15, 2021

Conversation

yusufpapurcu
Copy link
Contributor

Error covered without change function definition

Error covered without change function definition
@google-cla
Copy link

google-cla bot commented Jan 7, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@yusufpapurcu
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Collaborator

@pborman pborman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These error checks are unnecessary:

type Hash interface {
    // Write (via the embedded io.Writer interface) adds more data to the running hash.
    // It never returns an error.
    io.Writer

@yusufpapurcu
Copy link
Contributor Author

So we need to add //nolint:errcheck because if we don't add it will fails in linting.

@pborman
Copy link
Collaborator

pborman commented Jan 15, 2021

Thank you. FYI, the other option is just saying _, _ = h.Write(...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants