Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint dependency on go-critic issue w/ golang 1.13 (works w/ <=golang:1.12.7) #1786

Closed
DazWilkin opened this issue Aug 6, 2019 · 2 comments · Fixed by #1801
Closed
Assignees

Comments

@DazWilkin
Copy link
Contributor

Heads-up

Step #0: Pulling image: golang:1.13-rc-buster
Step #0: Digest: sha256:90c836736aff2a2fef8ad80240d2c40eb256d705c71b2cffbd502faab2bf61ea
Step #0: Status: Downloaded newer image for golang:1.13-rc-buster
Step #0: go: github.com/google/trillian@v1.3.0 requires
Step #0: 	github.com/golangci/golangci-lint@v1.17.2-0.20190630074125-360a58dca92d requires
Step #0: 	github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540: reading https://proxy.golang.org/github.com/go-critic/go-critic/@v/v0.0.0-20181204210945-1df300866540.mod: 410 Gone
Finished Step #0
ERROR
ERROR: build step 0 "golang:1.13-rc-buster" failed: exit status 1

Appears to be addressed by:
golangci/golangci-lint#605

The issue does not appear to arise with Golang versions <=1.12.7

@paulmattei paulmattei added this to Needs triage in Trillian Aug 7, 2019
@paulmattei paulmattei removed this from Needs triage in Trillian Aug 7, 2019
@DazWilkin
Copy link
Contributor Author

The issues appear to be related to the proxy (and not Trillian or its dependencies); I'm using Cloud Build and, reading some of the commits on here, I reverted to GOPROXY=direct and everything now builds.

Filed: golang/go#33530

@bcmills
Copy link

bcmills commented Aug 7, 2019

These are real issues exposed by the fact that the proxy is now using go1.13beta1. See https://tip.golang.org/doc/go1.13#version-validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants