Google sync #609
Merged
Google sync #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imes.
A TGP turned up code that does things like:
class Foo:
def __init__(self):
self.x = [] # type: List[X]
def reset(self):
self.x = [] # type: List[X]
Due to some weirdness around hashing parameterized classes, this stores two
bindings for x's annotation, leading to spurious "must be constant" errors
later on. Fixed by ignoring the second annotation.
PiperOrigin-RevId: 318332546
PiperOrigin-RevId: 318389448
For #608. I fixed a pyi parser issue about two weeks ago, and we need to do a release so that typeshed can use the fix. I don't feel confident releasing at head (too many findings to click through to check if there are any new crashes, obvious bugs, etc.), so what I plan to do is to temporarily roll back the change that generates the vast majority of the new findings, release on PyPI, and then reapply that change. PiperOrigin-RevId: 318522426
I derped and put June 28 instead of June 26. PiperOrigin-RevId: 318525801
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.