Google sync #543
Merged
Google sync #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 303789067
assertRegexpMatches is deprecated in favor of assertRegex in Python 3, and assertRaisesRegexp was renamed to assertRaisesRegex in 3.2. Just for consistency, I also changed all other references to "regexp" I could find. Lastly, fixes two g-missing-super-call lint warnings. PiperOrigin-RevId: 303799439
Now that we have comment-based error checking, I really wanted to be able to insert expected errors into test code and have them checked without needing to call a separate assert method afterwards. This CL: * Fixes a couple cases where errors were reported in a non-deterministic order, so that a mark can always be associated with the right error. * Has CheckWithErrors and InferWithErrors call assert_errors_match_expected() on the errorlog. * Forbids adding expected error comments to Check, Infer, and InferFromFile, so that we don't accidentally use one of these methods and have our expected errors silently ignored. * Replaces assertErrorLogIs and assertErrorsMatch with an assertErrorRegexes method that only has to be called when we want to check marks. * Makes some simplifications to the line number handling and error matching code that are possible because of the removal of assertErrorLogIs. On its own, this CL does not pass tests; a follow-up will migrate all uses of assertErrorLogIs over to assertErrorRegexes. I'll wait until both CLs have been reviewed, then submit them in quick succession. PiperOrigin-RevId: 303863481
PiperOrigin-RevId: 303864672
Related: Resolves #541 PiperOrigin-RevId: 304020432
Also removes now-unnecessary g-backslash-continuation suppressions and fixes g-generic-assert errors in pytype/errors_test. PiperOrigin-RevId: 304021801
The latter is not available in Python 2 *sigh* I increased the shard count of a test that timed out. PiperOrigin-RevId: 304034251
The issue that caused the tests to be skipped is fixed. I had to fix one of the tests to stop returning an awaitable from __aiter__ (https://www.python.org/dev/peps/pep-0492/#why-aiter-does-not-return-an-awaitable, https://docs.python.org/3/library/dis.html#opcode-GET_AITER). PiperOrigin-RevId: 304042948
Just a normal release, despite the date =) PiperOrigin-RevId: 304251409
* self.assertCountEqual does not exist in Python 2. * Dictionaries are not insertion ordered in Python 3.5. PiperOrigin-RevId: 304261311
… 3.5. Ughhh PiperOrigin-RevId: 304291925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.