Google sync #1206
Merged
Google sync #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `a.pyi` contains `from b import *`, `a` wiil only reexport symbols from `b.__all__`. PiperOrigin-RevId: 448552151
The `ast` library doesn't add the end_lineno attribute, which the preprocessor uses, until 3.8. PiperOrigin-RevId: 448573419
… file. PiperOrigin-RevId: 448589096
Uses argument-by-argument function call matching for PyTDFunction in cases in which no generic classes or functions are involved in the call. Keeping both the old and new matching implementations around is unfortunately very messy (I was surprised how much more complicated PyTDFunction is than InterpreterFunction!), but we should be able to clean this up considerably once the old implementation is gone. What I ended up doing was creating a dummy view (a variable->variable identity mapping) that the new implementation could pass to helper methods that expect a view. Where necessary, we're also passing around a `variable` argument to indicate whether the view values are bindings or variables. I branched PyTDSignature.substitute_formal_args because I thought that made the code cleaner-looking, rather than trying to save a few lines by factoring out common code between the two implementations. PiperOrigin-RevId: 449077864
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.