Google sync #1036
Merged
Google sync #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes a crash caused by an overly specific assert. * Puts the new dict() changes behind a feature flag, --build-dict-literals-from-kwargs. (Would love suggestions for a less wordy name...) PiperOrigin-RevId: 404872878
…pes...}]`.
Also applies a similar transform to `collection.namedtuple`. No type information of course, but the number of elements is now part of the type like with `typing.Tuple[Any, Any{, ...}]`
This fixes the last piece of `NamedTuple` being considered a type safe `Tuple` too.
As this is a breaking change, this is gaurded behind a `--strict_namedtuple_checks` flag. But this will become the default in the near future.
Before this, this code would erronously pass
```python
from typing import NamedTuple, Tuple
class X(NamedTuple):
a: int
b: str
x = X(42, "the answer")
dual_strings: Tuple[str, str] = x # This should fail type checking, first element of X is an int
a_str: str = x[0] # This should fail type checking too
```
Now it fails properly.
This also helps with some IDEs who are unaware of the extra context pytype keeps track of and thought `X` was a plain `tuple`, but not a `Tuple[int, str]`, so it wouldn't know the types after accessing them through tuple methods.
For example, with `X` and `x` as given above, for the construct: `a, b = x`, some IDE's would see the `tuple` "superclass" and assume `a` and `b` were `Any`.
Now it should treat it the same way as if it was `Tuple[int, str]` and preserve the typing. (Same with indexed element access)
Also, patches one hole in the type enforcement of the classic `collections.namedtuple`, where it would lose track of the size of the `Tuple` and would allow arbitrary sized destructuring assignment.
Before this, this code would erroneously pass
```python
import collections
X = collections.namedtuple("X", ["a", "b", "c"])
x = X("Friday", "Night", "Funkin")
a, b, c, d = x # This should fail type checking, there are only 3 elements
a, b = x # This should fail too
```
Now it fails properly
PiperOrigin-RevId: 404882510
I also added a line to the CHANGELOG entry for last week's release for a change that I forgot to mention. PiperOrigin-RevId: 405460692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.