Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google sync #1017

Merged
merged 4 commits into from Sep 30, 2021
Merged

Google sync #1017

merged 4 commits into from Sep 30, 2021

Conversation

rchen152
Copy link
Contributor

No description provided.

rchen152 and others added 4 commits September 29, 2021 17:29
@rchen152
Call init_class instead of instantiate when adding assertIsInstance b…
fa208ca 
…indings.

PiperOrigin-RevId: 399302004
@rchen152
Use the namedtuple 'defaults' argument when generating __new__ signat…
3505ca2 
…ure.

PiperOrigin-RevId: 399323256
@martindemello @rchen152
Do not raise a parser error for unrecognised decorators.
afaa829 
PiperOrigin-RevId: 399325093
@Solumin @rchen152
Stop differentiating between enum and member attributes.
f5b7398 
Two reasons for this:
- pytype doesn't differentiate between class and instance attributes for PytdClass. This change makes enums behave the same as other PytdClasses.
- Canonical instances (e.g. created for a function argument) won't have instance attributes if they're deleted from the PytdClass.

PiperOrigin-RevId: 399486408
@google-cla google-cla bot added the cla: yes label Sep 30, 2021
@rchen152 rchen152 merged commit 5be9b24 into master Sep 30, 2021
@rchen152 rchen152 deleted the google_sync branch September 30, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rchen152 @martindemello @Solumin