Skip to content
This repository has been archived by the owner on Dec 12, 2021. It is now read-only.

Port bug fix for clobbered assets #15

Open
fotinakis opened this issue Jul 20, 2018 · 0 comments
Open

Port bug fix for clobbered assets #15

fotinakis opened this issue Jul 20, 2018 · 0 comments

Comments

@fotinakis
Copy link

Hello! We fixed a high-priority asset discovery bug in ember-percy and noticed that the gatherBuildResources method was also duplicated into this project with the same bug present.

The bug is present here:

function gatherBuildResources(percyClient, buildDirs, rootDirs) {

You should upgrade percy-client to 2.10.0, and then remove gatherBuildResources entirely and use the new method present on PercyClient objects: percyClient.gatherBuildResources.

See here for a reference bugfix from ember-percy: percy/percy-ember#70

Key to note: the method now returns an array, instead of a hash. If you need the hash you'll want to construct it in the same way as in the above reference.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant