Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconfigiure Maven phases i.e when to generate soy files. #2847

Merged
merged 6 commits into from Nov 3, 2022

Conversation

penmetsaa
Copy link
Contributor

@penmetsaa penmetsaa commented Nov 2, 2022

Issue:

  • Without the fix, mvn install OR mvn release:publish after abruptly getting ended after the log line:
    [INFO] --- exec-maven-plugin:3.1.0:java (soy-compiler) @ demo ---
  • No further steps are getting executed like publishing the code to Sonatype remote account.

Cause:

  • The SOY code generator classes kills the main thread that invokes them;
  • this is not going well with exec-maven-plugin as it executes the main programs in its main thread synchrounusly.

After the fix, the build steps like mvn install are getting completed with success message.

@google google deleted a comment from lonnieashley72 Nov 3, 2022
@penmetsaa penmetsaa merged commit aeddc85 into master Nov 3, 2022
@penmetsaa penmetsaa deleted the Fix_Maven_release_for_demo branch November 3, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants