Improve encoding of values to handle null cases #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically with enums and converter functions when `includeIfNull` is `false`. Enum values with `null` as an output where not properly wrapped. This is now fixed. Fixes #1202 Also 'unwrap' the cases where conversion functions never return `null`.
jakemac53
approved these changes
Oct 17, 2022
Comment on lines
+24
to
+26
| if (enumMap == null) return null; | ||
|
|
||
| return enumMap.values.contains(null); |
There was a problem hiding this comment.
Suggested change
| if (enumMap == null) return null; | |
| return enumMap.values.contains(null); | |
| return enumMap?.values.contains(null); |
Comment on lines
+157
to
+161
| if (data == null) { | ||
| return null; | ||
| } | ||
|
|
||
| return data.jsonType.isNullableType; |
There was a problem hiding this comment.
Suggested change
| if (data == null) { | |
| return null; | |
| } | |
| return data.jsonType.isNullableType; | |
| return data?.jsonType.isNullableType; |
|
Oh rofl, auto merge for the lose.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically with enums and converter functions when
includeIfNullisfalse.Enum values with
nullas an output where not properly wrapped.This is now fixed.
Fixes #1202
Also 'unwrap' the cases where conversion functions never return
null.