Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with defaultValue as function with DateTime #1219

Closed
kevmoo opened this issue Oct 7, 2022 · 1 comment · Fixed by #1220
Closed

Problem with defaultValue as function with DateTime #1219

kevmoo opened this issue Oct 7, 2022 · 1 comment · Fixed by #1220
Assignees
@kevmoo
Labels
pkg:json_serializable Type: bug

Comments

@kevmoo
Copy link
Collaborator

kevmoo commented Oct 7, 2022

Hrm...

  @JsonKey(defaultValue: DateTime.now)
  DateTime funWithDateTime;

with a required param creates

      funWithDateTime:
          DateTime.parse(json['funWithDateTime'] as String) ?? DateTime.now(),

Which is not good!
@kevmoo
Copy link
Collaborator Author

kevmoo commented Oct 7, 2022

See #1185 (comment)

@kevmoo kevmoo self-assigned this Oct 7, 2022
This was referenced Oct 7, 2022
Closed
Merged
kevmoo added a commit that referenced this issue Oct 7, 2022
@kevmoo
Fix BigInt, DateTime, Uri JsonKey.defaultValue w/ a function
0b4ae8f 
Fixes #1219

Prepare to release v6.5.1
kevmoo added a commit that referenced this issue Oct 10, 2022
@kevmoo
Fix BigInt, DateTime, Uri JsonKey.defaultValue w/ a function (#1220)
a79c6b7 
Fixes #1219

Prepare to release v6.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevmoo kevmoo

Labels
pkg:json_serializable Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix BigInt, DateTime, Uri JsonKey.defaultValue w/ a function google/json_serializable.dart
1 participant
@kevmoo