Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JsonConverter docs example #1193

Merged
merged 2 commits into from Aug 28, 2022
Merged

Fix JsonConverter docs example #1193

merged 2 commits into from Aug 28, 2022

Conversation

feinstein
Copy link
Contributor

@feinstein feinstein commented Aug 28, 2022 •
edited

The docs have an example where the Converter class name differs from when it's used as an annotation.

Closes #1194.

@feinstein feinstein changed the title Fix docs example Fix JsonConverter docs example Aug 28, 2022
@kevmoo
Copy link
Collaborator

kevmoo commented Aug 28, 2022

Thanks, @feinstein !

@kevmoo kevmoo merged commit 10dd2ee into google:master Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix JsonConverter docs example
2 participants
@feinstein @kevmoo