Support ConstructorElement
#1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @kevmoo |
kevmoo
reviewed
Aug 11, 2022
json_serializable/test/supported_types/input.type_duration.dart
Outdated
Show resolved
Hide resolved
|
Plan to fix the tests here, @AlexV525 ? |
These analyze failures seem not realted to the PR it self, but with the analyzer's callers. Should I do some rebase? |
|
@AlexV525 – yup, you'll want to rebase! |
AlexV525
force-pushed
the
support-constructor-element
branch
from
a69494e
to
308e0fe
Compare
Done. 😃 |
kevmoo
requested changes
Sep 15, 2022
json_serializable/test/supported_types/input.type_duration.dart
Outdated
Show resolved
Hide resolved
|
Test has been added to |
|
@AlexV525 – we now have merge conflicts. |
kevmoo
approved these changes
Sep 28, 2022
|
Thanks, Kevin @kevmoo ! |
|
Thank you!
…On Thu, Sep 29, 2022 at 12:21 AM Alex Li ***@***.***> wrote:
Thanks, Kevin @kevmoo <https://github.com/kevmoo> !
—
Reply to this email directly, view it on GitHub
<#1183 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEFCXFZHPAOUJDOFUV4HTWAU7OBANCNFSM55RQNCWA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to a14n/dart-decimal#59 (comment).