JavaDoc bug in JsonArray and JsonElement classes #1908
Labels
Comments
HiFromAjay
added a commit
to HiFromAjay/gson
that referenced
this issue
Jun 11, 2021
… getAsDouble, getAsInt, getAsJsonArray, getAsJsonObject, getAsLong, and getAsString methods of JsonArray class. These test cases, which we wrote according to the specified behavior of each method, that helped us in identifying the documentation bugs in JsonArray and JsonElement classes, which we submitted issues for (Issue google#1908). Note that we have adapted these test cases based on similar tests from the JSON-java project (https://github.com/stleary/JSON-java).
HiFromAjay
added a commit
to HiFromAjay/gson
that referenced
this issue
Jun 14, 2021
…ods [use fail(...), use JsonArray methods, remove unused values, formatting, google#1909, google#1908]
HiFromAjay
added a commit
to HiFromAjay/gson
that referenced
this issue
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The JavaDoc description of
getAsDoublemethod inJsonArrayandJsonElementclasses states that the method throws “ClassCastException if the element is of not a JsonPrimitive and is not a valid double value.” However, it actually throws anUnsupportedOperationExceptionif the element is not aJsonPrimitivetype such asJsonObject. Whereas, it throws aNumberFormatExceptionif the element is not a valid double value such as string. The behavior is the same forgetAsIntandgetAsLongmethods.The JavaDoc description of
getAsBooleanmethod inJsonArrayandJsonElementclasses states that the method throws “ClassCastException if the element is of not a JsonPrimitive and is not a valid boolean value.” However, it actually throws anUnsupportedOperationExceptionif the element is not aJsonPrimitivetype such asJsonObject. Whereas, it does not throw any exception (returnsfalse) if the element is not a valid boolean value such as string and double. It is not clear though whether the bug is in the documented behavior or the implemented behavior. The behavior is the same for thegetAsStringmethod.The text was updated successfully, but these errors were encountered: