Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rule '-keep class * implements com.google.gson.TypeAdapter' uses implements but actually matches extends. #1658

Closed
JasonTian23 opened this issue Feb 24, 2020 · 2 comments

Comments

@JasonTian23
Copy link

“-keep class * implements com.google.gson.TypeAdapter” in examples/android-proguard-example/proguard.cfg is not valid. TypeAdapter is abstract class, not a interface.

Should use: -keep class * extends com.google.gson.TypeAdapter

@Marcono1234
Copy link
Collaborator

Fixed by #1693

@Marcono1234
Copy link
Collaborator

As mentioned above, this has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants