Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for java.sql types #1629

Closed
dernasherbrezon opened this issue Dec 4, 2019 · 6 comments · Fixed by #1707
Closed

Remove support for java.sql types #1629

dernasherbrezon opened this issue Dec 4, 2019 · 6 comments · Fixed by #1707

Comments

@dernasherbrezon
Copy link

The original idea #134 was OK in 2015. Since then, Java got modular support and java.sql is no longer available by default. This is causing sporadic issues in random places:

Would be great to deprecate support for java.sql and suggest writing type adapters instead.

@Marcono1234
Copy link
Collaborator

requires transitive java.sql;

Would have to be changed as well, right?

@inder123
Copy link
Collaborator

I am not as familiar with Java 10+ (as have stayed mostly with Android). So, if someone was willing to write a PR that maintains full backward compatibilty, I will take a look.

@dernasherbrezon
Copy link
Author

Lol, it can't be backward compatible because of "Remove support".

@Marcono1234
Copy link
Collaborator

I think it can be backwards compatible by using an optional module dependency (requires static) and then not trying to load any SQL classes if they are not present.
I have a local branch which should hopefully solve this, but I am not confident enough in it, so it will take a few days before I will create a pull request.

@inder123
Copy link
Collaborator

Wonderful!
Please write some tests as well. Backward compatibility is paramount for Gson as lots and lots of projects depend on it.

@Marcono1234
Copy link
Collaborator

Created #1707 now. Though I am not that familiar with the module system so any feedback is appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants