Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gson OSGi metadata claims support for JavaSE-1.5 but target generation is 1.6 #1602

Closed
briandealwis opened this issue Oct 31, 2019 · 2 comments

Comments

@briandealwis
Copy link
Contributor

Although the OSGi metadata claims Gson will work with Java 1.5 or greater:

Bundle-RequiredExecutionEnvironment: J2SE-1.5, JavaSE-1.6, JavaSE-1.7, JavaSE-1.8

the compilation configuration sets the target as 1.5 and the classes themselves are Java 1.6:

gson/pom.xml

Lines 89 to 95 in 47b28d9

<configuration>
<jdkToolchain>
<version>[1.5,9)</version>
</jdkToolchain>
<source>1.6</source>
<target>1.6</target>
</configuration>

$ file gson/target/classes/com/google/gson/Gson.class
gson/target/classes/com/google/gson/Gson.class:                       compiled Java class data, version 50.0 (Java 1.6)

And that looks to have been a decision made a while ago #790.

@elharo
Copy link
Contributor

elharo commented Nov 7, 2019

fixed by #1603

@chanseokoh
Copy link
Member

Please close this.

odl-github pushed a commit to opendaylight/odlparent that referenced this issue Dec 10, 2019
This reverts commit edbeb3e, as
GSON 2.8.6 seems to have quite a bit of trouble:

google/gson#1601
google/gson#1602
google/gson#1608
google/gson#1630

Let's wait for the dust to settle first.

Change-Id: I7d0c7b671a31bf9bf3a1861cc56b009bd0f724b6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants