Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some deprecations & warnings in tests #1522

Merged
merged 1 commit into from Oct 3, 2019
Merged

Clean up some deprecations & warnings in tests #1522

merged 1 commit into from Oct 3, 2019

Conversation

Degubi
Copy link
Contributor

@Degubi Degubi commented Apr 27, 2019

  • Add some SuppressWarnings("unused") to some fields & classes that are used in reflection code.
  • Replace MoreAsserts.assertEquals with Assert.assertArrayEquals.
  • Replace primitive wrapper constructor calls with autoboxing or explicit valueOf calls. (Wrapper class constructors deprecated after j9)
  • Fix wrong assert imports in MoreAsserts & JsonReaderPathTest.
  • Noticed that one of the test methods are failing when using newer java versions in DefaultDateTypeAdapterTest.java, there's already a pr for that: Implemented Fixes suggested by #1432 #1454
  • Was thinking about refactoring all the test methods to use the Junit4 @test annotations instead of using the TestCase class

@Degubi Degubi changed the title Clean up some deprecation stuff & warnings in tests Clean up some deprecations & warnings in tests Jun 27, 2019
@inder123 inder123 self-assigned this Oct 3, 2019
@inder123 inder123 merged commit 7845c38 into google:master Oct 3, 2019
@Degubi Degubi deleted the tests_cleanup branch October 5, 2019 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants