From a9cfde3002b0e62f285a31515e35c12b258502dd Mon Sep 17 00:00:00 2001 From: el10savio Date: Wed, 10 Nov 2021 18:18:47 +0530 Subject: [PATCH 1/2] Validate processInfo period & log a fatal error in the case of negative duration --- main.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/main.go b/main.go index 1b73131c..c3467a14 100644 --- a/main.go +++ b/main.go @@ -136,6 +136,9 @@ func processes() { } func processInfo(pid int, period time.Duration) { + if period < 0 { + log.Fatalf("Cannot process with negative duration: %v", period) + } p, err := process.NewProcess(int32(pid)) if err != nil { log.Fatalf("Cannot read process info: %v", err) @@ -152,10 +155,8 @@ func processInfo(pid int, period time.Duration) { if v, err := p.CPUPercent(); err == nil { fmt.Printf("cpu usage:\t%.3f%%\n", v) } - if period > 0 { - if v, err := cpuPercentWithinTime(p, period); err == nil { - fmt.Printf("cpu usage (%v):\t%.3f%%\n", period, v) - } + if v, err := cpuPercentWithinTime(p, period); err == nil { + fmt.Printf("cpu usage (%v):\t%.3f%%\n", period, v) } if v, err := p.Username(); err == nil { fmt.Printf("username:\t%v\n", v) From cec8c291a19aaa28a289af62e7ab4a5092c9f4be Mon Sep 17 00:00:00 2001 From: Elton SV Date: Wed, 10 Nov 2021 18:35:01 +0530 Subject: [PATCH 2/2] Update main.go Co-authored-by: Tobias Klauser --- main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.go b/main.go index c3467a14..a85b0752 100644 --- a/main.go +++ b/main.go @@ -137,7 +137,7 @@ func processes() { func processInfo(pid int, period time.Duration) { if period < 0 { - log.Fatalf("Cannot process with negative duration: %v", period) + log.Fatalf("Cannot determine CPU usage for negative duration %v", period) } p, err := process.NewProcess(int32(pid)) if err != nil {