This repository was archived by the owner on Jan 10, 2024. It is now read-only.
Fix bug where NilChance(0) could still result in nil #47
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because rand.Float64 can return 0 it was possible for this function to return false when the nilChance is set to 0 (because 0 > 0 = false).
ericcornelissen
changed the title
|
LGTM, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46.
As discussed there, using
NilChance(0)to prevent gofuzz from givingnils contained a very minor bug where it might still givenilbecause a randomly sampled0is not greater than the configured0. This has been fixed by using>=instead of>when comparing the configurednilChanceagainst randomly sampled values.I also added a test case where a seeded RNG is used which will give
0as it's first value in order to verify the bug is not reintroduced. Let me know if I should change anything about the test (or feel free to commit those changes yourself 🙂).