Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for repository actions access level / permission #2578

Merged
merged 2 commits into from Dec 1, 2022
Merged

Add support for repository actions access level / permission #2578

merged 2 commits into from Dec 1, 2022

Conversation

s4nji
Copy link
Contributor

@s4nji s4nji commented Nov 28, 2022

@codecov
Copy link

codecov bot commented Nov 28, 2022 •
edited

Codecov Report

Merging #2578 (22536e1) into master (621c4ba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2578   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files         125      126    +1     
  Lines       10875    10894   +19     
=======================================
+ Hits        10656    10675   +19     
  Misses        150      150           
  Partials       69       69
Impacted Files Coverage Δ
github/repos_actions_access.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gmlewis
gmlewis requested changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @s4nji !
Just a couple minor tweaks, please, then we will be ready for a second LGTM+Approval from any other contributor to this repo before merging.

github/repos_actions_access.go Outdated Show resolved Hide resolved
github/repos_actions_access.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 28, 2022
@s4nji @gmlewis
Apply suggestions from code review
22536e1 
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
gmlewis approved these changes Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @s4nji !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

valbeat
valbeat approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@valbeat valbeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 1, 2022

Thank you, @valbeat !
Merging.

@gmlewis gmlewis merged commit 0621dee into google:master Dec 1, 2022
@s4nji s4nji deleted the patch/repos-actions-access branch December 2, 2022 06:52
@s4nji s4nji mentioned this pull request Dec 13, 2022
Closed
1 task
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valbeat valbeat valbeat approved these changes

@gmlewis gmlewis gmlewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for repository actions permissions access
3 participants
@s4nji @gmlewis @valbeat