Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add merge_group webhook event via MergeGroupEvent and MergeGroup structs #2556

Merged
merged 2 commits into from Nov 5, 2022
Merged

Add merge_group webhook event via MergeGroupEvent and MergeGroup structs #2556

merged 2 commits into from Nov 5, 2022

Conversation

lyoung-confluent
Copy link
Contributor

Adds the structs for the new merge_group webhook event used by the Pull Request Merge Queue Limited Beta.

I'm not sure what the policy is on merging structs that are subject to change:

Note: The pull request merge queue feature is currently in limited public beta and subject to change.

@google-cla
Copy link

google-cla bot commented Nov 3, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #2556 (6c695c1) into master (3bfe921) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2556   +/-   ##
=======================================
  Coverage   97.97%   97.98%           
=======================================
  Files         124      124           
  Lines       10840    10842    +2     
=======================================
+ Hits        10621    10623    +2     
  Misses        150      150           
  Partials       69       69           
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)
github/messages.go 100.00% <ø> (ø)
github/event.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 3, 2022

I'm not sure what the policy is on merging structs that are subject to change:

We tend to live on the cutting edge in this repo, so we have no problem with that, as the GitHub v3 API seems to be a continuously-moving target in my experience. That's not a criticism... they seem to be continuously innovating, and we're just trying our best to keep up. 😄

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lyoung-confluent !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

github/event_types.go Outdated Show resolved Hide resolved
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 3, 2022
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Nov 5, 2022
@gmlewis gmlewis merged commit 16cdd7d into google:master Nov 5, 2022
@gmlewis
Copy link
Collaborator

gmlewis commented Nov 5, 2022

Thank you, @valbeat !
Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants