Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to io/ioutil package #2547

Merged
merged 1 commit into from Nov 7, 2022
Merged

Remove references to io/ioutil package #2547

merged 1 commit into from Nov 7, 2022

Conversation

austinvazquez
Copy link
Contributor

@austinvazquez austinvazquez commented Oct 31, 2022

Package io/ioutil has been deprecated in Go 1.16.

Signed-off-by: Austin Vazquez austin.vazquez.dev@gmail.com

@google-cla
Copy link

google-cla bot commented Oct 31, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @austinvazquez !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

EDIT: Also awaiting signed CLA before merging.

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. waiting for signed CLA labels Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #2547 (b18a767) into master (331265b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2547   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files         124      124           
  Lines       10842    10842           
=======================================
  Hits        10623    10623           
  Misses        150      150           
  Partials       69       69           
Impacted Files Coverage Δ
github/github.go 97.37% <100.00%> (ø)
github/messages.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Nov 6, 2022
@gmlewis
Copy link
Collaborator

gmlewis commented Nov 6, 2022

Thank you, @valbeat !

Still awaiting signed CLA before merging.

Package io/ioutil has been deprecated in Go 1.16.

Signed-off-by: Austin Vazquez <austin.vazquez.dev@gmail.com>
@austinvazquez
Copy link
Contributor Author

@gmlewis apologies for delay. Signed CLA and performed a rebase from master branch.

@gmlewis
Copy link
Collaborator

gmlewis commented Nov 7, 2022

@gmlewis apologies for delay. Signed CLA and performed a rebase from master branch.

No problem, @austinvazquez ! No apology necessary. Thank you!

@gmlewis gmlewis merged commit 9598613 into google:master Nov 7, 2022
@austinvazquez austinvazquez deleted the remove-ioutil branch November 7, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants