Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apps to restriction rules in branch protection #2509

Merged
merged 2 commits into from Oct 20, 2022
Merged

Add apps to restriction rules in branch protection #2509

merged 2 commits into from Oct 20, 2022

Conversation

jporzucek
Copy link
Contributor

Fixes #2506

@google-cla
Copy link

google-cla bot commented Oct 19, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gmlewis
gmlewis requested changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jporzucek .

go.mod Outdated Show resolved Hide resolved
go.sum Outdated Show resolved Hide resolved
gmlewis
gmlewis approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jporzucek !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #2509 (52055a1) into master (3dcfcf6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2509   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files         123      123           
  Lines       10813    10813           
=======================================
  Hits        10594    10594           
  Misses        150      150           
  Partials       69       69
Impacted Files Coverage Δ
github/repos.go 98.67% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

raynigon
raynigon approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@raynigon raynigon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 20, 2022

LGTM

Thank you, @raynigon !
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 20, 2022
@gmlewis gmlewis merged commit fce4030 into google:master Oct 20, 2022
@jporzucek jporzucek deleted the dev branch October 20, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmlewis gmlewis gmlewis approved these changes

@raynigon raynigon raynigon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add apps to restriction rules in branch protection
3 participants
@jporzucek @gmlewis @raynigon