Add explicit error return #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2469 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 122 122
Lines 10692 10695 +3
=======================================
+ Hits 10482 10485 +3
Misses 144 144
Partials 66 66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gmlewis
reviewed
Sep 17, 2022
github/repos_contents.go
Outdated
Comment on lines
322
to
323
| } | ||
| return parsedURL, newResponse(resp), nil |
There was a problem hiding this comment.
I know this is another thing that is inconsistent across this repo, but while I'm thinking about it, let's go ahead and add a blank line between the error handling and the final return, please.
Suggested change
| } | |
| return parsedURL, newResponse(resp), nil | |
| } | |
| return parsedURL, newResponse(resp), nil |
|
Note that I'm going to change the title of this PR because it is technically not an "unhandled error"... it is simply an error that is not explicitly tested for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.