Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for list Code Scan Alerts by Org #2346

Merged
merged 2 commits into from May 2, 2022

Conversation

AbbanMustafa
Copy link
Contributor

@AbbanMustafa AbbanMustafa commented Apr 28, 2022

Provide functionality for querying Code Scan Alerts by Github Org. As well as support a Repository field within each Alert object.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AbbanMustafa , but it looks like your unit tests are not passing yet.

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #2346 (a10da90) into master (ca149ad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2346   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         119      119           
  Lines       10471    10487   +16     
=======================================
+ Hits        10267    10283   +16     
  Misses        140      140           
  Partials       64       64           
Impacted Files Coverage Δ
github/code-scanning.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca149ad...a10da90. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @AbbanMustafa !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Copy link
Contributor

@ganeshkumarsv ganeshkumarsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis
Copy link
Collaborator

gmlewis commented May 2, 2022

Thank you, @ganeshkumarsv !
Merging.

@gmlewis gmlewis merged commit ac3b1e2 into google:master May 2, 2022
@AbbanMustafa
Copy link
Contributor Author

AbbanMustafa commented May 4, 2022

@gmlewis Thanks! When can I expect a new version to be released?

@gmlewis
Copy link
Collaborator

gmlewis commented May 4, 2022

@gmlewis Thanks! When can I expect a new version to be released?

Well, we just released v44 so usually we release every 30-60 days or so, but there are a few options...

You could import this version directly by the commit hash that includes this change or we could make a minor release probably next Sunday or Monday when I get back to my computer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants