Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLSA provenance verification broken for 0.13.0 #1539

Closed
imjasonh opened this issue Jan 24, 2023 · 1 comment · Fixed by #1540
Closed

SLSA provenance verification broken for 0.13.0 #1539

imjasonh opened this issue Jan 24, 2023 · 1 comment · Fixed by #1540

Comments

@imjasonh
Copy link
Collaborator

https://github.com/google/go-containerregistry/releases/tag/v0.13.0 was cut earlier, and the verification phase of the release failed: https://github.com/google/go-containerregistry/actions/runs/3998908027/jobs/6862265563

Download assets
  gh -R "$GITHUB_REPOSITORY" release download "$GITHUB_REF_NAME" -p "*.tar.gz"
  gh -R "$GITHUB_REPOSITORY" release download "$GITHUB_REF_NAME" -p "attestation.intoto.jsonl"
no assets match the file pattern

And indeed, there isn't any attestation.intoto.jsonl in the release, there's only multiple.intoto.jsonl.

The provenance generation and verification steps of the 0.12.0 and 0.12.1 and 0.11.0 releases also had breakages:

Unless we can be sure that provenance is generated and can be verified correctly, I'm sort of inclined to remove the attestation until they can be made more reliable. It's worse to me to have misleading or broken or unverifiable provenance than to have no provenance at all.

@asraa @laurentsimon

@laurentsimon
Copy link
Contributor

/cc @ianlewis
Theattestation.intoto.jsonl was renamed to multiple.intoto.jsonl and the semver of the builder did not reflect that change.
Let me send a PR to update the file name in the verification part. Sorry about this. Nothing is broken, the attestation still exists and verification will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants