Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8schain: Log and proceed if secret or SA are not found #1472

Merged
merged 1 commit into from Oct 23, 2022

Conversation

imjasonh
Copy link
Collaborator

Fixes #1471

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2022

Codecov Report

Merging #1472 (b3f92f6) into main (3413eb6) will not change coverage.
The diff coverage is n/a.

❗ Current head b3f92f6 differs from pull request most recent head 59d71d1. Consider uploading reports for the commit 59d71d1 to get more accurate results

@@           Coverage Diff           @@
##             main    #1472   +/-   ##
=======================================
  Coverage   73.18%   73.18%           
=======================================
  Files         115      115           
  Lines        8809     8809           
=======================================
  Hits         6447     6447           
  Misses       1712     1712           
  Partials      650      650           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one comment.

@imjasonh
Copy link
Collaborator Author

Good catch, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8schain: does not ignore missing pull secrets like Kubernetes does
3 participants