Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crane's root.go after DefaultTransport change #1450

Merged
merged 1 commit into from Sep 20, 2022

Conversation

imjasonh
Copy link
Collaborator

#1449 changed remote.DefaultTransport to be a http.RoundTripper instead of a *http.Transport, and made a corresponding change in crane to call Clone only if the provided RoundTripper was also cloneable. It was overly clever, and unnecessary, and seems to have broken crane's insecure repo support.

@codecov-commenter
Copy link

Codecov Report

Merging #1450 (18c1e41) into main (f981b4c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1450   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files         115      115           
  Lines        8772     8772           
=======================================
  Hits         6431     6431           
  Misses       1696     1696           
  Partials      645      645           
Impacted Files Coverage Δ
pkg/v1/remote/options.go 71.81% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mattmoor mattmoor merged commit 9a5c14a into google:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants