Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump opencontainers/image-spec #1423

Merged
merged 4 commits into from Aug 2, 2022

Conversation

shubham1172
Copy link
Contributor

Signed-off-by: Shubham Sharma shubhash@microsoft.com

This PR updates the version of https://github.com/opencontainers/image-spec to the latest commit.
This latest version of image-spec does not contain golangci-lint as a dependency in go.mod, which further had GPLv3 transitive dependencies.

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@imjasonh
Copy link
Collaborator

imjasonh commented Aug 2, 2022

Looks like this needs a go mod vendor as well.

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Copy link
Contributor Author

shubham1172 commented Aug 2, 2022

Thanks @imjasonh, can you please re-trigger the workflows?
EDIT: ran go mod tidy.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #1423 (b06754d) into main (24a1c33) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1423   +/-   ##
=======================================
  Coverage   73.40%   73.40%           
=======================================
  Files         115      115           
  Lines        8757     8757           
=======================================
  Hits         6428     6428           
  Misses       1688     1688           
  Partials      641      641           

Help us with your feedback. Take ten seconds to tell us how you rate us.

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
@shubham1172
Copy link
Contributor Author

Looks like there were some other go.sum files too, as part of the presubmit check. Have updated those.

@imjasonh imjasonh merged commit c1f9836 into google:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants