Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Remove indirect dependency to github.com/prometheus/prometheus #3312

Closed
gunturaf opened this issue Aug 29, 2023 · 6 comments
Closed

all: Remove indirect dependency to github.com/prometheus/prometheus #3312

gunturaf opened this issue Aug 29, 2023 · 6 comments

Comments

@gunturaf
Copy link

Is your feature request related to a problem? Please describe.

Currently, this library requires contrib.go.opencensus.io/exporter/stackdriver in its go.mod file,
however, the version used here (v0.13.14) imports github.com/prometheus/prometheus, while in reality it does not need to import the whole prometheus, just a little copy is OK which done by me via census-ecosystem/opencensus-go-exporter-stackdriver#316

I think it's beneficial if this library upgrade its usage to the master branch of contrib.go.opencensus.io/exporter/stackdriver.

Describe the solution you'd like

Upgrade contrib.go.opencensus.io/exporter/stackdriver to master branch, since that library is now deprecated and no new tag was created since the above MR was merged.

Describe alternatives you've considered

Replace stackdriver exporter to similar library since OpenCensus is now deprecated anyway.

Additional context

https://github.com/google/go-cloud/blob/master/go.mod#L28C10-L28C10

@vangent
Copy link
Contributor

vangent commented Aug 29, 2023

When is the next tag/release for contrib.go.opencensus.io/exporter/stackdriver going to happen? Can't we just wait for that?

@gedw99
Copy link

gedw99 commented Sep 1, 2023

Al their repos are dead

https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver/

anyone know what’s happening?

@gedw99
Copy link

gedw99 commented Sep 1, 2023

https://opentelemetry.io/blog/2023/sunsetting-opencensus/

It’s now in Otel basically

@gedw99
Copy link

gedw99 commented Sep 1, 2023

@vangent

are you going to port or bridge ?

https://github.com/open-telemetry/opentelemetry-go/tree/main/bridge/opencensus Is the bridge.

my 2 cents.. port . Don’t know if your insulated at an API level inside CDK

@gunturaf
Copy link
Author

gunturaf commented Sep 1, 2023

When is the next tag/release for contrib.go.opencensus.io/exporter/stackdriver going to happen? Can't we just wait for that?

I'm afraid that new tags won't be happening since OpenCensus is deprecated since OpenTelemetry released; just like @gedw99 wrote in the above messages.

For all I care, I just want to remove the indirect dependency to prometheus/prometheus that the late OpenCensus stackdriver brings, so that my repository that depends to krakend-jose (in this line https://github.com/krakend/krakend-jose/blob/master/go.mod#L9 ) which depends to this project (in this line https://github.com/google/go-cloud/blob/master/go.sum#L1199-L1200 ) can feel a little 'lighter' by not needing to download the whole Prometheus project when compiling.

Pardon that I don't really know how OpenCensus stackdriver library being used in this project, but I'm happy to help if there's another alternative to resolve this; as long as the alternative won't indirectly require large project such as Prometheus.

@vangent
Copy link
Contributor

vangent commented Sep 16, 2023

The right answer here is to port to using OpenTelemetry. There is already an issue open for that (#2877) so I'm going to close this one; I don't think pointing to a master branch of a deprecated library is appropriate.

@vangent vangent closed this as completed Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants