Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/gcsblob: update proto import #3228

Merged
merged 1 commit into from
Feb 25, 2023
Merged

blob/gcsblob: update proto import #3228

merged 1 commit into from
Feb 25, 2023

Conversation

Multiply
Copy link
Contributor

@Multiply Multiply commented Feb 20, 2023

Similar to the fix in #3227

I chose to split the remaining fixes up into 4 smaller PRs, the others being: #3229 #3230 #3231

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #3228 (c24cd50) into master (7cd8b2b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3228   +/-   ##
=======================================
  Coverage   77.34%   77.34%           
=======================================
  Files         103      103           
  Lines       13548    13548           
=======================================
  Hits        10479    10479           
  Misses       2340     2340           
  Partials      729      729           
Impacted Files Coverage Δ
blob/gcsblob/iam.go 94.44% <ø> (ø)
blob/s3blob/s3blob.go 89.43% <0.00%> (-0.28%) ⬇️
internal/retry/retry.go 100.00% <0.00%> (+11.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Multiply
Copy link
Contributor Author

I force pushed to retest, as I couldn't seem to trigger it any other way. No changes.

@vangent vangent merged commit e5235d8 into google:master Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants