blobl/fileblob: Add a custom createTemp function that uses consistent file permissions. #3166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A take at trying to make the file permissions consistent between directories, blob files and attribute files.
Rather than using a syscall to grab the umask, we replace
os.CreateTemp
/ioutil.TempFile
with our own version that uses the permissions we desire.Differences with
os.CreateTemp
:time.UnixNano()
instead offastrand()
This has the following implications:
time.UnixNano()
)Fixes #3165