pubsub/kafka: Allow overriding batching options for Topic #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3163 +/- ##
==========================================
- Coverage 72.84% 72.81% -0.03%
==========================================
Files 113 113
Lines 14387 14388 +1
==========================================
- Hits 10480 10477 -3
- Misses 3180 3185 +5
+ Partials 727 726 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
danielorbach
added a commit
to danielorbach/go-cloud
that referenced
this pull request
Jan 15, 2023
The [examples][ExampleOpenTopic] show a simple call to `OpenTopic` without `kafkapubsub.TopicOptions` as passing a `nil` argument. This is backed by replacing a `nil` pointer with the appropriate zero-value. This behaviour exists in `OpenSubscription` too. However, PR google#3163 introduced overriding batching options which inadvertently accesses a field of a nil pointer. [ExampleOpenTopic]: https://github.com/google/go-cloud/blob/master/pubsub/kafkapubsub/example_test.go#L36
danielorbach
added a commit
to danielorbach/go-cloud
that referenced
this pull request
Jan 15, 2023
`ExampleOpenTopic` (pubsub/kafkapubsub/example_test.go) show a simple call to `OpenTopic` without `kafkapubsub.TopicOptions` as passing a `nil` argument. This is done by replacing a `nil` pointer with the appropriate zero-value. This behaviour exists in `OpenSubscription` too. However, PR google#3163 introduced overriding batching options which inadvertently accesses a field of a nil pointer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3162.