Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/azureblob: add storage_account query parameter #3159

Merged
merged 2 commits into from Aug 12, 2022

Conversation

ekini
Copy link
Contributor

@ekini ekini commented Aug 11, 2022

This PR adds "storage_account" as possible query string parameter to the URL.

It'll allow opening multiple storage accounts using the same credentials.

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #3159 (49a1715) into master (58fd166) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3159      +/-   ##
==========================================
- Coverage   72.81%   72.80%   -0.02%     
==========================================
  Files         113      113              
  Lines       14385    14387       +2     
==========================================
  Hits        10474    10474              
- Misses       3185     3187       +2     
  Partials      726      726              
Impacted Files Coverage Δ
blob/azureblob/azureblob.go 84.12% <100.00%> (+0.06%) ⬆️
blob/s3blob/s3blob.go 89.43% <0.00%> (-0.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ekini ekini force-pushed the feature/azblob_storage_account branch from fb9c084 to 03704ec Compare August 12, 2022 10:14
@vangent vangent merged commit 2ae6e17 into google:master Aug 12, 2022
@ekini ekini deleted the feature/azblob_storage_account branch October 6, 2022 08:47
ekini added a commit to ekini/pulumi-hugo that referenced this pull request Oct 6, 2022
AaronFriel added a commit to pulumi/pulumi-hugo that referenced this pull request Oct 10, 2022
* Add storage_account parameter to Azure Blob Storage backend

to use cli auth

Related to pulumi/pulumi#10900
Related to google/go-cloud#3159

Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
aaronkao pushed a commit to pulumi/pulumi-hugo that referenced this pull request Nov 1, 2022
* Add storage_account parameter to Azure Blob Storage backend

to use cli auth

Related to pulumi/pulumi#10900
Related to google/go-cloud#3159

Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants