Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/azureblob: Update to new beta azblob BREAKING_CHANGE_OK #3156

Merged
merged 1 commit into from Aug 10, 2022

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Aug 6, 2022

No description provided.

@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #3156 (a872e82) into master (cf4fa6f) will increase coverage by 0.18%.
The diff coverage is 80.23%.

@@            Coverage Diff             @@
##           master    #3156      +/-   ##
==========================================
+ Coverage   72.61%   72.79%   +0.18%     
==========================================
  Files         113      113              
  Lines       14407    14341      -66     
==========================================
- Hits        10462    10440      -22     
+ Misses       3227     3181      -46     
- Partials      718      720       +2     
Impacted Files Coverage Δ
samples/guestbook/wire_gen.go 0.00% <ø> (ø)
blob/azureblob/azureblob.go 84.06% <80.23%> (+5.69%) ⬆️
internal/retry/retry.go 88.23% <0.00%> (-11.77%) ⬇️
pubsub/rabbitpubsub/rabbit.go 80.56% <0.00%> (-0.63%) ⬇️
blob/s3blob/s3blob.go 89.71% <0.00%> (+0.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vangent vangent merged commit 0c45fa6 into google:master Aug 10, 2022
@vangent vangent deleted the azblob branch August 10, 2022 21:23
gitlab-runner-bot pushed a commit to gitlabhq/gitlab-runner that referenced this pull request Nov 9, 2022
This upgrade will require Go 1.18+: google/go-cloud#3141.

Per https://github.com/Azure/azure-sdk-for-go/tree/main/sdk/storage/azblob#readme,
the new Azure SDK is now `github.com/Azure/azure-sdk-for-go/sdk/storage/azblob`.
The migration in google/go-cloud#3156 also had
a number of breaking API changes.

This commit has been validated to work with Azure Blob Storage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant