Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob: make blob.Reader implement io.ReadSeekCloser #3145

Merged
merged 1 commit into from Jul 6, 2022

Conversation

vangent
Copy link
Contributor

@vangent vangent commented Jul 5, 2022

Fixes #3142

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #3145 (60f681d) into master (6f96f91) will increase coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #3145      +/-   ##
==========================================
+ Coverage   72.45%   72.46%   +0.01%     
==========================================
  Files         112      112              
  Lines       14286    14329      +43     
==========================================
+ Hits        10351    10384      +33     
- Misses       3222     3230       +8     
- Partials      713      715       +2     
Impacted Files Coverage Δ
blob/blob.go 89.13% <75.00%> (-1.29%) ⬇️
docstore/docstore.go 87.76% <0.00%> (-1.80%) ⬇️
runtimevar/awsparamstore/awsparamstore.go 88.63% <0.00%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f96f91...60f681d. Read the comment docs.

@vangent vangent force-pushed the rsc2 branch 2 times, most recently from 9a04da5 to cd5f240 Compare July 5, 2022 19:08
@vangent vangent changed the title blob: add a blob.ReadSeekCloser blob: make blob.Reader implement io.ReadSeekCloser Jul 5, 2022
@vangent vangent force-pushed the rsc2 branch 3 times, most recently from 3ea57b9 to 1a690a2 Compare July 5, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blob: http.ServeContent support
1 participant