Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub: Add Message.LoggableID #2998

Merged
merged 3 commits into from May 13, 2021
Merged

pubsub: Add Message.LoggableID #2998

merged 3 commits into from May 13, 2021

Conversation

vangent
Copy link
Contributor

@vangent vangent commented May 13, 2021

An opaque field useful only for debugging and logging.

Fixes #2994.

@vangent vangent requested a review from eliben May 13, 2021 02:36
@google-cla google-cla bot added the cla: yes Google CLA has been signed! label May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #2998 (a0a1443) into master (5f19477) will increase coverage by 0.08%.
The diff coverage is 89.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2998      +/-   ##
==========================================
+ Coverage   69.33%   69.42%   +0.08%     
==========================================
  Files         111      111              
  Lines       11628    11652      +24     
==========================================
+ Hits         8062     8089      +27     
+ Misses       2899     2897       -2     
+ Partials      667      666       -1     
Impacted Files Coverage Δ
pubsub/azuresb/azuresb.go 20.00% <0.00%> (-0.10%) ⬇️
secrets/azurekeyvault/akv.go 46.39% <ø> (+2.06%) ⬆️
pubsub/awssnssqs/awssnssqs.go 83.01% <100.00%> (+0.05%) ⬆️
pubsub/gcppubsub/gcppubsub.go 75.90% <100.00%> (+0.14%) ⬆️
pubsub/kafkapubsub/kafka.go 81.96% <100.00%> (+0.45%) ⬆️
pubsub/mempubsub/mem.go 79.20% <100.00%> (+0.16%) ⬆️
pubsub/natspubsub/nats.go 72.22% <100.00%> (+0.34%) ⬆️
pubsub/pubsub.go 92.15% <100.00%> (+0.16%) ⬆️
pubsub/rabbitpubsub/rabbit.go 78.98% <100.00%> (+0.46%) ⬆️
blob/s3blob/s3blob.go 89.47% <0.00%> (+0.52%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f004cb7...a0a1443. Read the comment docs.

@vangent vangent merged commit d284dbe into google:master May 13, 2021
@vangent vangent deleted the msgid branch May 13, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub/pubsub: Add MessageId and PublishTime fields in Message type
2 participants